Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actor-Critic Support #259

Merged
merged 12 commits into from
Aug 15, 2024
Merged

Actor-Critic Support #259

merged 12 commits into from
Aug 15, 2024

Conversation

dlangbe
Copy link
Collaborator

@dlangbe dlangbe commented Aug 5, 2024

  • Re-enables support for actor-critic contraction kernel selection.
  • Adds fix for complex-type memory leak in contraction tests.
  • Adds new hiptensorLogLevel_t: HIPTENSOR_LOG_LEVEL_AC_TRAINING

cgmillette
cgmillette previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

cgmillette
cgmillette approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgmillette
Copy link
Collaborator

@CongMa13 @mkarunan any thoughts?

mkarunan
mkarunan approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@mkarunan mkarunan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CongMa13
CongMa13 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@CongMa13 CongMa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlangbe dlangbe merged commit 833ee93 into ROCm:develop Aug 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmillette cgmillette cgmillette approved these changes

@mkarunan mkarunan mkarunan approved these changes

@CongMa13 CongMa13 CongMa13 approved these changes

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@afanfa afanfa Awaiting requested review from afanfa afanfa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlangbe @cgmillette @mkarunan @CongMa13